Skip to content

refactor(agg-mode): reduce types, abstractions and double merkle root in PI #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 30 commits into from
Apr 28, 2025
Merged

refactor(agg-mode): reduce types, abstractions and double merkle root in PI #1889

MauroToscano merged 30 commits into from
Apr 28, 2025

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Apr 24, 2025 •
edited
Loading

Description

This refactor includes:

  • A simplification of the codebase by reducing the number of types and eliminating unnecessary abstractions.
  • Relocating the Merkle root off-VM and the in-VM check outside the VM. This way, we avoid repeatead public inputs.

Type of change

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau
feat: risc0 aggregation program
3200e0c
@MarcosNicolau
feat: [wip] risc0 aggregator backend
2f54502
@MarcosNicolau
feat: ProofAggregationService risc0 verification
62bfb60
@MarcosNicolau
feat: error handling + fetch risc0 proofs
c475a63
@MarcosNicolau
feat: send risc0 aggregated proof to AlignedProofAggregationService c…
e2dcf30 
…ontract
@MarcosNicolau
feat: deploy AlignedProofAggregationService contract with risc0 verifier
1c4440b
@MarcosNicolau
feat: allow risc0 succinct proofs
df1d83a
@MarcosNicolau
chore: modified risc0 no_pub_inputs to generate a succinct proof inst…
4bc1a52 
…ead of a composite
@MarcosNicolau
feat: fetch proofs based on zkvm engine
56a9d87
@MarcosNicolau
chore: commands to start proof agregator based on verifier
6c544d0
@MarcosNicolau
fix: compute image id bytes in little endian not in be
b137020
@MarcosNicolau
feat: local verification of aggregated risc0 proof
d0a4be6
@MarcosNicolau
Merge branch 'staging' into feat/aggregation-mode-risc0
8309ea8
@MarcosNicolau
chore: add gpu feature flag to run with cuda
369cdc6
@MarcosNicolau
docs: add gpu command
7720553
@MarcosNicolau
chore: undo no_pub_input file changes
ebdc910
@MarcosNicolau
ci: fix contracts build + install risc0 toolchain
1b8873a
@MarcosNicolau
chore: better proof aggregator makefile targets
01f60f4
@MarcosNicolau
docs: update how to run proof aggregator readme
20b7d61
@MarcosNicolau
ci: skip build on clippy
454f80c
@MarcosNicolau
chore: address clippy warnings
5e43630
@MarcosNicolau
fix: correctly setting risc0 tiny-keccak patch
79eb6b3
@MarcosNicolau
chore: rename prove feature to proving to prevent collision with risc…
bd5ad9d 
…0 features
@MarcosNicolau
Revert "chore: rename prove feature to proving to prevent collision w…
ef2b968 
…ith risc0 features"

This reverts commit bd5ad9d.
@MarcosNicolau
chore: address juli's comments
319c112
@MarcosNicolau
refactor: replace sp1,risc0 features for .env variables
ac646c6
@MarcosNicolau
chore: update makefile for new aggregator env config
74f15be
@MarcosNicolau
refactor: aggregation mode reduce amount of types and abstractions
b63e875
Base automatically changed from feat/aggregation-mode-risc0 to staging April 24, 2025 20:06
@MauroToscano MauroToscano enabled auto-merge April 28, 2025 19:45
@MauroToscano MauroToscano added this pull request to the merge queue Apr 28, 2025
Merged via the queue into staging with commit 5d78e56 Apr 28, 2025
3 checks passed
@MauroToscano MauroToscano deleted the refactor/agg-mode-redundancies branch April 28, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

Assignees

@MarcosNicolau MarcosNicolau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcosNicolau @MauroToscano @JuArce